Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and improvements for the 23.1.0 test schema #57

Merged
merged 5 commits into from
Aug 23, 2024
Merged

Fixes and improvements for the 23.1.0 test schema #57

merged 5 commits into from
Aug 23, 2024

Conversation

odow
Copy link
Collaborator

@odow odow commented Aug 22, 2024

Part of #37

I'm working through issues locally with

diff --git a/test/runtests.jl b/test/runtests.jl
index aa65798..45513d0 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -12,7 +12,7 @@ import JSON3
 import OrderedCollections
 import ZipFile
 
-const TEST_SUITE_URL = "https://github.com/json-schema-org/JSON-Schema-Test-Suite/archive/2.0.0.zip"
+const TEST_SUITE_URL = "https://github.com/json-schema-org/JSON-Schema-Test-Suite/archive/23.1.0.zip"
 
 const SCHEMA_TEST_DIR = let
     dest_dir = mktempdir()
@@ -26,7 +26,7 @@ const SCHEMA_TEST_DIR = let
             write(filename, read(f, String))
         end
     end
-    joinpath(dest_dir, "test-suite", "JSON-Schema-Test-Suite-2.0.0", "tests")
+    joinpath(dest_dir, "test-suite", "JSON-Schema-Test-Suite-23.1.0", "tests")
 end
 
 const LOCAL_TEST_DIR = mktempdir(SCHEMA_TEST_DIR)

I'm currently at:

Some tests did not pass: 2209 passed, 13 failed, 17 errored, 0 broken.

@odow
Copy link
Collaborator Author

odow commented Aug 23, 2024

Some tests did not pass: 2226 passed, 4 failed, 13 errored, 0 broken.

@odow odow merged commit a1245c8 into master Aug 23, 2024
8 checks passed
@odow odow deleted the od/23.1.0 branch August 23, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant